Skip to content

Create GCI120 angular rule #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Create GCI120 angular rule #406

wants to merge 4 commits into from

Conversation

@hindsellouk
Copy link

@hindsellouk hindsellouk commented May 21, 2025

No description provided.

@MP-Aubay
Copy link
Contributor

MP-Aubay commented May 21, 2025

Hi @hindsellouk , could you :

  • Update the PR title like this "GCI120 [Team X][2025] - Angular rule"
  • Update CHANGELOG.md
  • Update RULES.md

@MP-Aubay MP-Aubay self-assigned this May 21, 2025
@MP-Aubay
Copy link
Contributor

MP-Aubay commented May 21, 2025

@hindsellouk I think this rule is to generic, Angular doc said that "It could be usefull" and "It may be effective on performance".

So this rule is situational and it's difficult to determine if it should be used (with static analysis)

utarwyn
utarwyn reviewed May 31, 2025
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for the first Angular rule proposal 🥳

I also think we lack precise measurements of the effectiveness and relevance of using OnPush rather than the default detection system. Can you provide us with precise documentation and why not run some benchmarks ourselves?

It will also be very useful to reference them in the rule documentation. In the meantime, I propose not to merge the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025

This PR has been automatically marked as stale because it has no activity for 60 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@utarwyn utarwyn utarwyn left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@MP-Aubay MP-Aubay

Labels

stale 👀 👀 waiting commiter 👀 👀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hindsellouk @MP-Aubay @utarwyn